Skip to content

[Forwardport] Fixed tierprice discount not calculated correctly if has specialprice#19179

Merged
magento-engcom-team merged 4 commits intomagento:2.3-developfrom
torhoehn:2.3-develop-PR-port-18743
Nov 16, 2018
Merged

[Forwardport] Fixed tierprice discount not calculated correctly if has specialprice#19179
magento-engcom-team merged 4 commits intomagento:2.3-developfrom
torhoehn:2.3-develop-PR-port-18743

Conversation

@torhoehn
Copy link
Copy Markdown
Contributor

@torhoehn torhoehn commented Nov 13, 2018

Original Pull Request

#18743

Description (*)

Added tierprice discount on speacial price, Check below link
Before: https://www.screencast.com/t/NyBdfLCb
After: https://www.screencast.com/t/na7rpDoKPvN

Fixed Issues (if relevant)

  1. Tierprice discount not calculated correctly if has specialprice. #18652: Tierprice discount not calculated correctly if has specialprice

Manual testing scenarios (*)

  1. Add new product with price $100
  2. Add special price $80
  3. Add tier price with qty=2, type = "Discount" and value = "%12"
  4. Add tier price with qty=300, type = "Discount" and value = "%25"
  5. Add tier price with qty=1000, type = "Discount" and value = "%50"
  6. Save the product

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Nov 13, 2018

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 13, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 13, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Nov 13, 2018

Hi @VladimirZaets, thank you for the review.
ENGCOM-3450 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Nov 16, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit d0ba997 into magento:2.3-develop Nov 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 16, 2018
@slavvka
ENGCOM-3450: [Forwardport] Fixed tierprice discount not calculated co…
0a12f2f 
…rrectly if has specialprice #19179
magento-engcom-team pushed a commit that referenced this pull request Nov 16, 2018
@slavvka
ENGCOM-3450: [Forwardport] Fixed tierprice discount not calculated co…
52a989c 
…rrectly if has specialprice #19179
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Nov 16, 2018

Hi @torhoehn. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@torhoehn torhoehn deleted the 2.3-develop-PR-port-18743 branch November 24, 2018 22:14
@nathanjosiah
Copy link
Copy Markdown
Contributor

nathanjosiah commented Mar 7, 2019

@torhoehn Thank you for your contribution! Unfortunately this PR had to be reverted for 2.3.1 as it created a new bug where a bundled product cannot be added to the cart on storefront with a special price applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels

Component: Catalog Partner: Basecom partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@torhoehn @magento-engcom-team @nathanjosiah @VladimirZaets @gelanivishal